Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate @fluentui/react-conformance-make-styles #20758

Merged
merged 4 commits into from
Nov 25, 2021
Merged

chore: migrate @fluentui/react-conformance-make-styles #20758

merged 4 commits into from
Nov 25, 2021

Conversation

layershifter
Copy link
Member

Pull request checklist

Description of changes

@layershifter layershifter requested a review from a team as a code owner November 24, 2021 13:54
@layershifter layershifter added the Status: Blocked Resolution blocked by another issue label Nov 24, 2021
@layershifter layershifter requested a review from a team November 24, 2021 13:54
@layershifter layershifter changed the title Chore/migrate rcmk chore: migrate @fluentui/react-conformance-make-styles Nov 24, 2021
@layershifter layershifter mentioned this pull request Nov 24, 2021
Closed
39 tasks
@fabricteam
Copy link
Collaborator

fabricteam commented Nov 24, 2021 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 532579ec884b3bad9e2db6dff139eb467f3c2bbc

@size-auditor
Copy link

size-auditor bot commented Nov 24, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8a820339f7f4084d8c46e97f06eebbeb18111397 (build)

@layershifter layershifter removed the Status: Blocked Resolution blocked by another issue label Nov 24, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6e1d00a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1050 997 5000
BaseButton mount 1064 1031 5000
Breadcrumb mount 2812 2806 1000
ButtonNext mount 648 629 5000
Checkbox mount 1666 1719 5000
CheckboxBase mount 1449 1426 5000
ChoiceGroup mount 4957 4918 5000
ComboBox mount 1073 1116 1000
CommandBar mount 10389 10358 1000
ContextualMenu mount 8643 8600 1000
DefaultButton mount 1333 1292 5000
DetailsRow mount 4047 3934 5000
DetailsRowFast mount 4041 4013 5000
DetailsRowNoStyles mount 3761 3747 5000
Dialog mount 2680 2720 1000
DocumentCardTitle mount 278 273 1000
Dropdown mount 3373 3438 5000
FluentProviderNext mount 4315 4319 5000
FluentProviderWithTheme mount 353 353 10
FluentProviderWithTheme virtual-rerender 243 205 10
FluentProviderWithTheme virtual-rerender-with-unmount 388 378 10
FocusTrapZone mount 1933 1901 5000
FocusZone mount 1948 1955 5000
IconButton mount 1991 1927 5000
Label mount 463 452 5000
Layer mount 3127 3132 5000
Link mount 621 614 5000
MakeStyles mount 1965 1961 50000
MenuButton mount 1589 1617 5000
MessageBar mount 2162 2135 5000
Nav mount 3376 3402 1000
OverflowSet mount 1257 1277 5000
Panel mount 2576 2603 1000
Persona mount 952 994 1000
Pivot mount 1558 1556 1000
PrimaryButton mount 1416 1426 5000
Rating mount 7864 7882 5000
SearchBox mount 1434 1425 5000
Shimmer mount 2660 2618 5000
Slider mount 2070 2088 5000
SpinButton mount 5204 5159 5000
Spinner mount 559 567 5000
SplitButton mount 3319 3339 5000
Stack mount 632 632 5000
StackWithIntrinsicChildren mount 1832 1789 5000
StackWithTextChildren mount 4778 4817 5000
SwatchColorPicker mount 10629 10840 5000
TagPicker mount 2766 2752 5000
TeachingBubble mount 13482 13463 5000
Text mount 524 572 5000
TextField mount 1522 1553 5000
ThemeProvider mount 1346 1341 5000
ThemeProvider virtual-rerender 728 732 5000
ThemeProvider virtual-rerender-with-unmount 2019 1977 5000
Toggle mount 977 932 5000
buttonNative mount 242 245 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 169 151 1.12:1
ChatDuplicateMessagesPerf.default 320 294 1.09:1
DropdownManyItemsPerf.default 726 675 1.08:1
AnimationMinimalPerf.default 436 409 1.07:1
PortalMinimalPerf.default 191 181 1.06:1
TreeWith60ListItems.default 194 183 1.06:1
GridMinimalPerf.default 350 335 1.04:1
InputMinimalPerf.default 1318 1271 1.04:1
RadioGroupMinimalPerf.default 459 440 1.04:1
SkeletonMinimalPerf.default 368 354 1.04:1
BoxMinimalPerf.default 353 343 1.03:1
EmbedMinimalPerf.default 4224 4102 1.03:1
ImageMinimalPerf.default 381 369 1.03:1
RefMinimalPerf.default 253 249 1.02:1
SliderMinimalPerf.default 1708 1677 1.02:1
ToolbarMinimalPerf.default 945 930 1.02:1
TooltipMinimalPerf.default 1036 1020 1.02:1
CheckboxMinimalPerf.default 2716 2701 1.01:1
DatepickerMinimalPerf.default 5612 5536 1.01:1
DialogMinimalPerf.default 777 770 1.01:1
HeaderMinimalPerf.default 368 366 1.01:1
LayoutMinimalPerf.default 358 353 1.01:1
ListCommonPerf.default 645 641 1.01:1
LoaderMinimalPerf.default 679 669 1.01:1
MenuMinimalPerf.default 854 842 1.01:1
ProviderMergeThemesPerf.default 1721 1698 1.01:1
ButtonOverridesMissPerf.default 1711 1716 1:1
CarouselMinimalPerf.default 484 485 1:1
DropdownMinimalPerf.default 3027 3033 1:1
FormMinimalPerf.default 416 418 1:1
ItemLayoutMinimalPerf.default 1189 1189 1:1
ProviderMinimalPerf.default 1109 1114 1:1
SegmentMinimalPerf.default 344 344 1:1
IconMinimalPerf.default 640 638 1:1
CustomToolbarPrototype.default 4083 4077 1:1
AlertMinimalPerf.default 277 280 0.99:1
AvatarMinimalPerf.default 201 204 0.99:1
ButtonSlotsPerf.default 562 569 0.99:1
FlexMinimalPerf.default 297 299 0.99:1
SplitButtonMinimalPerf.default 4225 4285 0.99:1
StatusMinimalPerf.default 673 683 0.99:1
TableManyItemsPerf.default 1906 1932 0.99:1
TableMinimalPerf.default 408 411 0.99:1
ListNestedPerf.default 555 568 0.98:1
ListWith60ListItems.default 634 647 0.98:1
MenuButtonMinimalPerf.default 1637 1669 0.98:1
RosterPerf.default 1175 1193 0.98:1
PopupMinimalPerf.default 600 613 0.98:1
CardMinimalPerf.default 565 582 0.97:1
ChatWithPopoverPerf.default 376 389 0.97:1
HeaderSlotsPerf.default 752 778 0.97:1
ListMinimalPerf.default 517 534 0.97:1
ReactionMinimalPerf.default 382 392 0.97:1
TreeMinimalPerf.default 799 820 0.97:1
AttachmentMinimalPerf.default 162 169 0.96:1
ChatMinimalPerf.default 657 686 0.96:1
DividerMinimalPerf.default 367 383 0.96:1
VideoMinimalPerf.default 607 633 0.96:1
AttachmentSlotsPerf.default 1076 1128 0.95:1
TextAreaMinimalPerf.default 491 515 0.95:1
ButtonMinimalPerf.default 184 195 0.94:1
LabelMinimalPerf.default 375 403 0.93:1
TextMinimalPerf.default 345 375 0.92:1

@layershifter layershifter merged commit edbe781 into master Nov 25, 2021
@layershifter layershifter deleted the chore/migrate-rcmk branch November 25, 2021 08:58
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@layershifter
chore: migrate @fluentui/react-conformance-make-styles (microsoft#20758)
f6bafa1 
* chore: migrate @fluentui/react-conformance-make-styles

* Change files

* update config

* applied suggestions from another PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 approved these changes

Assignees

@khmakoto khmakoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@layershifter @fabricteam @ling1726 @khmakoto